docs: fixed sidebar issue #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oll with toggle body overflow on and off
|
@skirianov is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@tannerlinsley can you take a look please? |
Member
|
Needs conflict resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #82
Fixes:
Why not simply remove the overflow from the body and keep scrolling only inside scroll containers?
In order to preserve the functionality of
<ScrollRestoration />on mobile, I needed to keep body overflow visible. Otherwise, we would lost the "scroll back to top" functionality on navigation between pagesWhy do we set
document.body.style.overflow = 'visible'insideDocs.tsx?Since the
toggleBodyOverflowfunction works only when sidebar is toggled on/off and does not return the body overflow value tovisibleif navigated to the main page (clicking on the logo), we have to set it explicitly tovisiblein the component itself.☝️ if you are aware of a better approach, please let me know, I would be happy to implement it :)